fix: rclone zombie where cron - #443
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
66449c7 to
f731bbd
Compare
| RUN apk add --no-cache rclone bash curl docker-cli tini | ||
| COPY --from=builder /app/autorestic /usr/bin/autorestic | ||
| ENTRYPOINT [] | ||
| ENTRYPOINT [ "/sbin/tini", "--" ] |
There was a problem hiding this comment.
There is an old changelog entry about handing signals and graceful shutdown - if I understand tini correctly, it'll kill the process on SIGTERM instead of letting it handle its own shutdown
There was a problem hiding this comment.
”All Tini does is spawn a single child (Tini is meant to be run in a container), and wait for it to exit all the while reaping zombies and performing signal forwarding.“
ref https://github.com/krallin/tini
tinit avoids zombies.
There was a problem hiding this comment.
There is an old changelog entry about handing signals and graceful shutdown - if I understand
tinicorrectly, it'll kill the process on SIGTERM instead of letting it handle its own shutdown
https://github.com/restic/restic/blob/master/internal/backend/rclone/backend.go#L85
cmd.Start no wait caused zombies. this pr is a workaroumd. It works in my homelab
2 participants
ref: rclone/rclone#8523